smoke tester isn't happy here, but it's a weird error which I don't think
should hold up the release:

[junit4:junit4]   2> NOTE: reproduce with: ant test
-Dtestcase=TestPerfTasksLogic -Dtests.method=testIndexingWithFacets
-Dtests.seed=4AC220973B1D6F81 -Dtests.slow=true -Dtests.locale=zh_TW
-Dtests.timezone=Africa/Asmera -Dtests.file.encoding=US-ASCII
[junit4:junit4] ERROR   0.23s J0 |
TestPerfTasksLogic.testIndexingWithFacets <<<
[junit4:junit4]    > Throwable #1: java.lang.ArrayIndexOutOfBoundsException
[junit4:junit4]    >    at
__randomizedtesting.SeedInfo.seed([4AC220973B1D6F81:6B60E7DA29775161]:0)
[junit4:junit4]    >    at
org.apache.lucene.facet.taxonomy.CategoryPath.toString(CategoryPath.java:212)

What's weird is that:
(1) I cannot reproduce, even though the test is deterministic
(2) CategoryPath is immutable, with its 'length' and 'components' members
final. I've gone through all the places where components and length are
set, and it seems impossible to have length be > components.length.

I've also asked Mike to take a look (maybe I'm missing something), and he
didn't find anything too. The only place where errors might happen is in
the private constructor which takes a prefixLen. But that's called only
from subpath(), which is guarded from all sides.

Mike and I suspect it might be a JVM issue (I used J9). I failed to repro
w/ iters and dups set to 1000.

So I don't think it should hold up the release. I will add an assert to
that constructor, just in case it will bite again.
If somebody else wants to take a look and confirm that the code is
protected, that would be great.

Shai


On Thu, Jan 17, 2013 at 3:28 PM, Michael McCandless <
luc...@mikemccandless.com> wrote:

> +1, smoke tester is happy.
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
> On Thu, Jan 17, 2013 at 7:49 AM, Simon Willnauer
> <simon.willna...@gmail.com> wrote:
> > smoke tester is happy
> >
> > +1 (binding)
> > On Thu, Jan 17, 2013 at 12:47 PM, Adrien Grand <jpou...@gmail.com>
> wrote:
> >> It passed for me too. +1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> > For additional commands, e-mail: dev-h...@lucene.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>

Reply via email to