[ 
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613326#comment-13613326
 ] 

Erick Erickson commented on SOLR-4632:
--------------------------------------

Hmmm, why did you remove the check in CoreContainer when persisting the 
transientCacheSize around line 1,300 (warning, I've made some other changes so 
the file lines may not match).

It seems incorrect to me to persist Integer.MAX_VALUE if nothing has ever been 
specified, just let the default value happen next time the file is read rather 
than leave the user wondering where the heck that came from.

You don't need to put up a new patch, I'll just change this in SOLR-4615 unless 
you convince me that this check is really a bad idea....


                
> transientCacheSize is not retained when persisting solr.xml
> -----------------------------------------------------------
>
>                 Key: SOLR-4632
>                 URL: https://issues.apache.org/jira/browse/SOLR-4632
>             Project: Solr
>          Issue Type: Bug
>          Components: multicore
>    Affects Versions: 4.2
>            Reporter: dfdeshom
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 4.3
>
>         Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was 
> able to reproduce this using the following solr.xml file:
> {code:xml}
> <?xml version="1.0" encoding="UTF-8" ?>
> <solr persistent="true">
>   <cores transientCacheSize="21" defaultCoreName="collection1" 
> adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}" 
> hostPort="8983" hostContext="solr">
>     <core name="collection1" collection="collection1"/>
>   </cores>
> </solr>
> {code}
> I created a new core:
> {code} curl 
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the 
> transientCacheSize attribute.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to