[ 
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614549#comment-13614549
 ] 

Erick Erickson commented on SOLR-4632:
--------------------------------------

Nope. Also, there's a test that's been in there from the beginning that 
verifies that if the value for transientCacheSize is other than 
Integer.MAX_VALUE, it's persisted. If it's not present, the default is 
Integer.MAX_VALUE. Reading that value is a bit opaque, it's easy to overlook. 

But in looking at the code, it was misleading at best. There's no way to change 
the value of transientCacheSize outside of having it in the solr.xml file in 
the <cores> tag, you can't dynamically change it. None of the create process 
for a core changes the value in the <cores> tag. Nor should it IMO.

So I don't understand what you're doing to test this. How are you changing the 
valur for transientCacheSize?

BTW, all that is entirely separate from not being able to specify loadOnStartup 
and transient when creating cores, I've include that patch in what I'm working 
on now.
                
> transientCacheSize is not retained when persisting solr.xml
> -----------------------------------------------------------
>
>                 Key: SOLR-4632
>                 URL: https://issues.apache.org/jira/browse/SOLR-4632
>             Project: Solr
>          Issue Type: Bug
>          Components: multicore
>    Affects Versions: 4.2
>            Reporter: dfdeshom
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 4.3
>
>         Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was 
> able to reproduce this using the following solr.xml file:
> {code:xml}
> <?xml version="1.0" encoding="UTF-8" ?>
> <solr persistent="true">
>   <cores transientCacheSize="21" defaultCoreName="collection1" 
> adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}" 
> hostPort="8983" hostContext="solr">
>     <core name="collection1" collection="collection1"/>
>   </cores>
> </solr>
> {code}
> I created a new core:
> {code} curl 
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the 
> transientCacheSize attribute.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to