We can change the build.xml to set the JAVA_6_HOME using ${java.home} and maybe
also check the special common-build.xml java version detection of the build VM.
Uwe
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: [email protected]
> -----Original Message-----
> From: Robert Muir [mailto:[email protected]]
> Sent: Tuesday, March 26, 2013 1:39 PM
> To: [email protected]
> Subject: Re: svn commit: r1461066 - /lucene/dev/branches/branch_4x/dev-
> tools/scripts/smokeTestRelease.py
>
> Thanks Mike!
>
> An additional idea: this makes it difficult to use the 'ant nightly-smoke'
> target
> as you now need to set 3 variables:
> JAVA6_HOME, JAVA7_HOME, and JAVA_HOME (which must be equal to
> JAVA6_HOME).
>
> Maybe someone has an idea to make this target either use JAVA6_HOME as
> JAVA_HOME, or at least fail immediately (rather than after an hour or so), if
> JAVA_HOME isn't 1.6?
>
> On Tue, Mar 26, 2013 at 4:56 AM, <[email protected]> wrote:
> > Author: mikemccand
> > Date: Tue Mar 26 11:56:13 2013
> > New Revision: 1461066
> >
> > URL: http://svn.apache.org/r1461066
> > Log:
> > make sure Java 1.6 was used to compile the JARs in binary release
> >
> > Modified:
> >
> > lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py
> >
> > Modified:
> > lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py
> > URL:
> > http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/dev-
> tools/s
> >
> cripts/smokeTestRelease.py?rev=1461066&r1=1461065&r2=1461066&view=d
> iff
> >
> ==========================================================
> ============
> > ========
> > ---
> > lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py
> > (original)
> > +++ lucene/dev/branches/branch_4x/dev-
> tools/scripts/smokeTestRelease.p
> > +++ y Tue Mar 26 11:56:13 2013
> > @@ -196,7 +196,9 @@ def checkJARMetaData(desc, jarFile, vers
> > # Make sure .class files are 1.6 format:
> > 'X-Compile-Target-JDK: 1.6',
> > # Make sure this matches the version we think we are releasing:
> > - 'Specification-Version: %s' % version):
> > + 'Specification-Version: %s' % version,
> > + # Make sure the release was compiled with 1.6:
> > + 'Created-By: 1.6'):
> > if s.find(verify) == -1:
> > raise RuntimeError('%s is missing "%s" inside its META-
> INF/MANIFES.MF' % \
> > (desc, verify))
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected] For additional
> commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
