Thanks Mike!

An additional idea: this makes it difficult to use the 'ant
nightly-smoke' target as you now need to set 3 variables:
JAVA6_HOME, JAVA7_HOME, and JAVA_HOME (which must be equal to JAVA6_HOME).

Maybe someone has an idea to make this target either use JAVA6_HOME as
JAVA_HOME, or at least fail immediately (rather than after an hour or
so), if JAVA_HOME isn't 1.6?

On Tue, Mar 26, 2013 at 4:56 AM,  <mikemcc...@apache.org> wrote:
> Author: mikemccand
> Date: Tue Mar 26 11:56:13 2013
> New Revision: 1461066
>
> URL: http://svn.apache.org/r1461066
> Log:
> make sure Java 1.6 was used to compile the JARs in binary release
>
> Modified:
>     lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py
>
> Modified: lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py
> URL: 
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py?rev=1461066&r1=1461065&r2=1461066&view=diff
> ==============================================================================
> --- lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py 
> (original)
> +++ lucene/dev/branches/branch_4x/dev-tools/scripts/smokeTestRelease.py Tue 
> Mar 26 11:56:13 2013
> @@ -196,7 +196,9 @@ def checkJARMetaData(desc, jarFile, vers
>        # Make sure .class files are 1.6 format:
>        'X-Compile-Target-JDK: 1.6',
>        # Make sure this matches the version we think we are releasing:
> -      'Specification-Version: %s' % version):
> +      'Specification-Version: %s' % version,
> +      # Make sure the release was compiled with 1.6:
> +      'Created-By: 1.6'):
>        if s.find(verify) == -1:
>          raise RuntimeError('%s is missing "%s" inside its 
> META-INF/MANIFES.MF' % \
>                             (desc, verify))
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to