[
https://issues.apache.org/jira/browse/LUCENE-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649638#comment-13649638
]
Shai Erera commented on LUCENE-4980:
------------------------------------
I was confused by the name MultiFacetsAccumulator as I thought it takes
something like a Map<FacetRequest,FacetsAccumulator>, but I see that it only
distinguishes RangeAccumulator from others. So I'm worried about someone gets
confused about the name and use it incorrectly. I don't have a better name in
mind though ... RangeAndRegularFacetsAccumulator?
What if RangeAccumulator did that under the covers? I.e. instead of rejecting
non-RangeFacetRequest, it created FA over all such requests? Multi is quite
simple though, so I like it .. maybe FacetAccumulatorRangeWrapper? I think as
long as we keep the word Range in the name, it's less likely users will get
confused.
Minor comments about the class: (a) can you rename 'a' and 'ra'? (b) why do you
need to hold onto fspOrig? Is it because FA.searchParams isn't final?
> Can't use DrillSideways with both RangeFacetRequest and non-RangeFacetRequest
> -----------------------------------------------------------------------------
>
> Key: LUCENE-4980
> URL: https://issues.apache.org/jira/browse/LUCENE-4980
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, 4.4
>
> Attachments: LUCENE-4980.patch
>
>
> I tried to combine these two and there were several issues:
> * It's ... really tricky to manage the two different
> FacetAccumulators across that N FacetCollectors that DrillSideways
> creates ... to fix this I added a new MultiFacetsAccumulator that
> switches for you.
> * There was still one place in DS/DDQ that wasn't properly handling
> a non-Term drill-down.
> * There was a bug in the "collector method" for DrillSideways
> whereby if a given segment had no hits, it was skipped, which is
> incorrect because it must still be visited to tally up the
> sideways counts.
> * Separately I noticed that DrillSideways was doing too much work:
> it would count up drill-down counts *and* drill-sideways counts
> against the same dim (but then discard the drill-down counts in
> the end).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
