[
https://issues.apache.org/jira/browse/LUCENE-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651063#comment-13651063
]
Shai Erera commented on LUCENE-4980:
------------------------------------
Thanks Mike. I think the TODO is a bit trickier than what it writes ... you
cannot decide to create SortedSetDVAccumulator based on a FacetRequest. App
needs to create it only if it indexed facets with SSDVFacetFields, right? This
might be possible if we had an index schema, of somehow expressed that
information in FacetIndexingParams.
So it's up to you to remove the TODO, but I don't think you can actually handle
it, currently, without app specifically telling you that it's ok.
> Can't use DrillSideways with both RangeFacetRequest and non-RangeFacetRequest
> -----------------------------------------------------------------------------
>
> Key: LUCENE-4980
> URL: https://issues.apache.org/jira/browse/LUCENE-4980
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, 4.4
>
> Attachments: LUCENE-4980.patch, LUCENE-4980.patch
>
>
> I tried to combine these two and there were several issues:
> * It's ... really tricky to manage the two different
> FacetAccumulators across that N FacetCollectors that DrillSideways
> creates ... to fix this I added a new MultiFacetsAccumulator that
> switches for you.
> * There was still one place in DS/DDQ that wasn't properly handling
> a non-Term drill-down.
> * There was a bug in the "collector method" for DrillSideways
> whereby if a given segment had no hits, it was skipped, which is
> incorrect because it must still be visited to tally up the
> sideways counts.
> * Separately I noticed that DrillSideways was doing too much work:
> it would count up drill-down counts *and* drill-sideways counts
> against the same dim (but then discard the drill-down counts in
> the end).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
