[
https://issues.apache.org/jira/browse/LUCENE-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679767#comment-13679767
]
Shai Erera commented on LUCENE-5038:
------------------------------------
Oh I see, sorry I didn't read through the issue.
So there will be two settings, one on IWC, the other on MP? What if a user sets
IWC to true and is unaware that MP may make such decision too, and actually but
default MP decides to keep large segments as non-CFS? Won't that be confusing?
How complicated is it to keep on MP only? Maybe MP can have the two settings
(at least they'll be on the same class!). IW will read it in the ctor and never
consult MP again for new flushed segments. User-wise, the settings are near
each other...
> Don't call MergePolicy / IndexWriter during DWPT Flush
> ------------------------------------------------------
>
> Key: LUCENE-5038
> URL: https://issues.apache.org/jira/browse/LUCENE-5038
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 4.3
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.4
>
> Attachments: LUCENE-5038.patch, LUCENE-5038.patch, LUCENE-5038.patch
>
>
> We currently consult the indexwriter -> merge policy to decide if we need to
> write CFS or not which is bad in many ways.
> - we should call mergepolicy only during merges
> - we should never sync on IW during DWPT flush
> - we should be able to make the decision if we need to write CFS or not
> before flush, ie. we could write parts of the flush directly to CFS or even
> start writing stored fields directly.
> - in the NRT case it might make sense to write all flushes to CFS to minimize
> filedescriptors independent of the index size.
> I wonder if we can use a simple boolean for this in the IWC and get away with
> not consulting merge policy. This would simplify concurrency a lot here
> already.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
