[
https://issues.apache.org/jira/browse/LUCENE-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679835#comment-13679835
]
Shai Erera commented on LUCENE-5038:
------------------------------------
I don't think we can tie MP and IWC. I.e. you normally do MP = new MP()
followed by new IWC().setMP(). IWC ctor already needs to set some value for
useCFS, so it defaults to say true, but when you setMP with say false, it's not
going to IWC.
I prefer that we keep that simple and seems that you and I agree that setCFS on
MP should go away. So we end with IWC.setCFS (defaults to true) and
MP.setNoCFSRatio (default is per impl?). And that's it? If want to turn off CFS
entirely, you do it in two places, but that's really expert. Otherwise we
default to CFS and you only need to decide whether you want merged segments to
be CFS or not, which is the more important decision I think.
> Don't call MergePolicy / IndexWriter during DWPT Flush
> ------------------------------------------------------
>
> Key: LUCENE-5038
> URL: https://issues.apache.org/jira/browse/LUCENE-5038
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 4.3
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.4
>
> Attachments: LUCENE-5038.patch, LUCENE-5038.patch, LUCENE-5038.patch
>
>
> We currently consult the indexwriter -> merge policy to decide if we need to
> write CFS or not which is bad in many ways.
> - we should call mergepolicy only during merges
> - we should never sync on IW during DWPT flush
> - we should be able to make the decision if we need to write CFS or not
> before flush, ie. we could write parts of the flush directly to CFS or even
> start writing stored fields directly.
> - in the NRT case it might make sense to write all flushes to CFS to minimize
> filedescriptors independent of the index size.
> I wonder if we can use a simple boolean for this in the IWC and get away with
> not consulting merge policy. This would simplify concurrency a lot here
> already.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
