[
https://issues.apache.org/jira/browse/LUCENE-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693113#comment-13693113
]
Robert Muir commented on LUCENE-5078:
-------------------------------------
I think this looks pretty good! So the norms "cache" and byte-ness gets moved
from TFIDF into DefaultXXX, but otherwise the API is pretty much the same.
The only concern i have is now DefaultSimilarity has non-final methods with
"long" signatures... which could lead to some traps. But maybe this is OK: if
someone were to inadvertently override encodeNormValue without changing
decodeNormValue, they are doing the wrong thing anyway right?
Maybe we can try to improve this with javadocs...
Or alternatively, maybe we should make these final in DefaultSimilarity, and if
you want to change norm *encoding* (not calculation, which can still be easily
tuned), really you should extend TFIDFSimilarity since its a pretty big change.
I would prefer this.
> Allow TfIdfSimilarity implementations to encode norm values into more than a
> single byte
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-5078
> URL: https://issues.apache.org/jira/browse/LUCENE-5078
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-5078.patch
>
>
> Continuation from here: http://lucene.markmail.org/message/jtwit3pwu5oiqr2h.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
