[
https://issues.apache.org/jira/browse/LUCENE-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693166#comment-13693166
]
Robert Muir commented on LUCENE-5078:
-------------------------------------
{quote}
That's a good point! What about if we make the whole change smaller by keeping
the byte-ness and cache in TfIdfSimilarity as a default impl (as it is now),
and only change the signature of encode/decode to long.
{quote}
I dunno, i think thats confusing: the whole point of this issue is to move that
byteness-implementation out of the abstract class and into the default
implementation right?
{quote}
If however we keep them on Default, I think they should be final there.
{quote}
I think thats all we need to do, make them final on default. otherwise patch is
good!
> Allow TfIdfSimilarity implementations to encode norm values into more than a
> single byte
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-5078
> URL: https://issues.apache.org/jira/browse/LUCENE-5078
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-5078.patch
>
>
> Continuation from here: http://lucene.markmail.org/message/jtwit3pwu5oiqr2h.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
