[
https://issues.apache.org/jira/browse/SOLR-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693468#comment-13693468
]
Hoss Man commented on SOLR-4943:
--------------------------------
I'm -0 on adding this new special "/admin/info" path ... CoreAdminHandler's
STATUS call seemed like a good place to return all of this info logic form, and
had the added benefit of already being a "special" handler with special
semantics and a solr.xml configurable path -- hence the idea i floated in
SOLR-4220.
(I know that between the collection admin paths and the restlet REST API paths
we've already moved into the point of there being "special" paths that the user
can't change in configuration -- i'd just really like to avoid adding any more
... but I'm not going to fight hard for it.)
Other then that, my concerns when looking at the patch...
* Having InfoHandler explicitly wrap instances of the existing
ThreadDumpHandler, PropertiesRequestHandler, LoggingHandler, and
SystemInfoHandler scares me (because of the "is CoreContainer null? is SolrCore
null?" situation) and seems overly complicated ... wouldn't it be just as easy
to refactor the meat of these classes into static methods (or helper objects)
that don't know about SolrQueryRequest and take in only hte specific item they
need (CoreContainer in SystemInfoHandler's case, and LowWatcher in
LoggingHandler's case, etc..) and then both InfoHandler and the original
handlers could call/instantiate those helpers?
* either way, we need some tests of this new InfoHandler (otherwise i guarantee
you someone down the road is going to add some code to one of these wrapped
handlers that is going to cause an NPE because it assumes it has access to a
SolrCore and it won't be caught until someone notices it in the UI)
** we also need more javadocs on all of the affected handlers noting the two
differnet usage patterns.
* why is there a change to SolrIndexSearcher in this patch? ... it smells
fishy ... is this a distinct bug that was discovered as part of your work on
hte patch that should be fixed & release noted in a dedicated issue?
> Add a new info admin handler.
> -----------------------------
>
> Key: SOLR-4943
> URL: https://issues.apache.org/jira/browse/SOLR-4943
> Project: Solr
> Issue Type: Improvement
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 5.0, 4.4
>
> Attachments: SOLR-4943-2.patch, SOLR-4943-3.patch, SOLR-4943.patch
>
>
> Currently, you have to specify a core to get system information for a variety
> of request handlers - properties, logging, thread dump, system, etc.
> These should be available at a system location and not core specific location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
