[ 
https://issues.apache.org/jira/browse/SOLR-5029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705184#comment-13705184
 ] 

Erick Erickson commented on SOLR-5029:
--------------------------------------

Oh dear. It's worse than that. Both ConfigSolr.xml and ConfigSolrOld.xml look 
for the shard definition directly under solr. CoreContainer.initShardHandler 
looks under solr/cores.

Ugly as the idea is, how about this? Support both positions (which will require 
initShardHandler looking in both places?) for 4.x. Only support the 
<shardHandlerFactory> as an immediate child node to <solr> in 5.0. And persist 
it to an immediate child of <solr> for 4.x which would, indeed, move it.
                
> shardHandlerFactory is not properly persisted
> ---------------------------------------------
>
>                 Key: SOLR-5029
>                 URL: https://issues.apache.org/jira/browse/SOLR-5029
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Ryan Ernst
>
> In SOLR-5028 I discovered persistence for shardHandlerFactory is only looking 
> for connTimeout and socketTimeout children.  Persistence should work for any 
> SHF impl, not just HttpShardHandlerFactory.  I think the thing to do here is 
> just copying the underlying Node to the new file, but the current persistence 
> code assumes a flat (String->String) hierarchy (which seems wrong, flat 
> hierarchy was one of the reasons myself and others were against 
> solr.properties).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to