[
https://issues.apache.org/jira/browse/SOLR-5029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705607#comment-13705607
]
Alan Woodward commented on SOLR-5029:
-------------------------------------
I think we need to get this fixed for 4.4, and worry about how we reconcile it
with SOLR-4914 later...
My suggestion:
- add an abstract getShardHandlerFactoryPluginInfo() to ConfigSolr which
returns the relevant PluginInfo, moving all the 'where do we get it' logic into
the two different ConfigSolrXXXX implementations. Use this in
initShardHandler().
- pass this PluginInfo to SolrCores.persistCores() instead of the
shardHandlerAttrib map.
I'll put together a patch.
> shardHandlerFactory is not properly persisted
> ---------------------------------------------
>
> Key: SOLR-5029
> URL: https://issues.apache.org/jira/browse/SOLR-5029
> Project: Solr
> Issue Type: Bug
> Reporter: Ryan Ernst
>
> In SOLR-5028 I discovered persistence for shardHandlerFactory is only looking
> for connTimeout and socketTimeout children. Persistence should work for any
> SHF impl, not just HttpShardHandlerFactory. I think the thing to do here is
> just copying the underlying Node to the new file, but the current persistence
> code assumes a flat (String->String) hierarchy (which seems wrong, flat
> hierarchy was one of the reasons myself and others were against
> solr.properties).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
