[
https://issues.apache.org/jira/browse/LUCENE-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705674#comment-13705674
]
Adrien Grand commented on LUCENE-5098:
--------------------------------------
The patch looks good to me. I'm looking forward to seeing the impact these
methods will have on the EliasFanoDocIdSet performance!
Some minor comments about the patch:
- Maybe these utility methods could be moved to oal.util.BitUtil where we
already have some utility methods to count or find bits?
- I ran quick benchmarks for select and select9 seemed to quickly outperform
selectNaive, even for non-dense longs. Do you have the same experience with
selectNaive vs. select9? If yes, maybe selectNaive could be moved to the test
case.
- Since the main goal of rank9 is code documentation, maybe it should be made
package-private?
> Broadword bit selection
> -----------------------
>
> Key: LUCENE-5098
> URL: https://issues.apache.org/jira/browse/LUCENE-5098
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Reporter: Paul Elschot
> Priority: Minor
> Attachments: LUCENE-5098.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
