[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756650#comment-13756650
]
Shai Erera commented on LUCENE-5189:
------------------------------------
Thanks for the review Mike. I nuked the two unused methodsand I like
SegmentCommitInfo, so changed the nocommit text.
I changed the nocomit in SIPC to a TODO. Don't think we need to tackle it in
this issue.
I'm working on improving the RAM accounting. I want to add to
NumericUpdate.sizeInBytes() and count it per-update that is actually added.
Then, because it's a Map<Term,Map<String,NumericUpdate>> and the Term and
String are both in NumericUdpate already (and will be accounted for in its
calculation, only their PTR needs to be taken into account. Also, the
sizeInBytes should grow by new entry to outer map only when one is actually
added, same for inner map. Therefore I don't think we can have a single
constant here, but instead maybe two: for every Entry<Term,Map> added to the
outer map and every Entry<String,NumericUpdate> added to the inner map. I
think, because I need to compute the shallow sizes only (since Term and String
are accounted for in NumericUpdate), it's a single constant for
Entry<Object,Object>?
> Numeric DocValues Updates
> -------------------------
>
> Key: LUCENE-5189
> URL: https://issues.apache.org/jira/browse/LUCENE-5189
> Project: Lucene - Core
> Issue Type: New Feature
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch,
> LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch
>
>
> In LUCENE-4258 we started to work on incremental field updates, however the
> amount of changes are immense and hard to follow/consume. The reason is that
> we targeted postings, stored fields, DV etc., all from the get go.
> I'd like to start afresh here, with numeric-dv-field updates only. There are
> a couple of reasons to that:
> * NumericDV fields should be easier to update, if e.g. we write all the
> values of all the documents in a segment for the updated field (similar to
> how livedocs work, and previously norms).
> * It's a fairly contained issue, attempting to handle just one data type to
> update, yet requires many changes to core code which will also be useful for
> updating other data types.
> * It has value in and on itself, and we don't need to allow updating all the
> data types in Lucene at once ... we can do that gradually.
> I have some working patch already which I'll upload next, explaining the
> changes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
