[
https://issues.apache.org/jira/browse/SOLR-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757323#comment-13757323
]
Erick Erickson commented on SOLR-2548:
--------------------------------------
This bit in SimpleFacets.getFacetFieldCounts bothers me:
int maxThreads =
Integer.parseInt(req.getParams().get(FacetParams.FACET_THREADS, "0"));
Executor executor = maxThreads == 0 ? directExecutor : facetExecutor;
maxThreads = maxThreads <= 0? Integer.MAX_VALUE : maxThreads;
It seems like if the user doesn't specify anything for FACET_THREADS, they wind
up spawning as many threads as there are facet fields specified. Probably not a
real problem given this list will be fairly small, but it seems more true to
the old default behavior if it's changed to something like
int maxThreads =
Integer.parseInt(req.getParams().get(FacetParams.FACET_THREADS, "1"));
Executor executor = maxThreads == 1 ? directExecutor : facetExecutor;
maxThreads = maxThreads < 1 ? Integer.MAX_VALUE : maxThreads;
Or am I seeing things that aren't there?
> Multithreaded faceting
> ----------------------
>
> Key: SOLR-2548
> URL: https://issues.apache.org/jira/browse/SOLR-2548
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 3.1
> Reporter: Janne Majaranta
> Assignee: Erick Erickson
> Priority: Minor
> Labels: facet
> Attachments: SOLR-2548_4.2.1.patch, SOLR-2548_for_31x.patch,
> SOLR-2548.patch
>
>
> Add multithreading support for faceting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
