[ 
https://issues.apache.org/jira/browse/LUCENE-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800896#comment-13800896
 ] 

Michael McCandless commented on LUCENE-5296:
--------------------------------------------

Thanks for the review Adrien!

bq. why do you substract 200 to Integer.MAX_VALUE to compute the maximum number 
of bytes/ords?

That's because the exact maximum size for an array seems to vary w/ JVMs to 
some "small" amount less than Integer.MAX_VALUE.  I'll put a comment explaining 
this ... actually, we also do this in BinaryDocValuesWriter; I'll factor it out 
& share it.

bq. sum looks unused in addNumericFieldValues

Woops, I'll remove.


> Add DirectDocValuesFormat
> -------------------------
>
>                 Key: LUCENE-5296
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5296
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.6, 5.0
>
>         Attachments: LUCENE-5296.patch
>
>
> Indexes values to disk but at search time it loads/accesses the values via 
> simple java arrays (i.e. no compression).



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to