GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/157

    Port CharArrayIterator

    This class has a BreakIterator concept that has no equivalent in .NET. 
However there is this project that is active and has a .NET bindings library 
available via nuget:
    
    http://site.icu-project.org/
    
    .NET library:
    https://github.com/niaher/icu4net
    
    I was able to use it and port CharArrayIterator tests which are all 
passing. It also looks like BreakIterator is used in other places in Analysis 
so we will have a solution for them with this PR.
    
    I did have to set platform to 32bit for analysis project in order for the 
tests to pass. ICU4NET and ICU dlls appear to be platform specific and only 32 
bit bindings are available for .NET. I was able to download icu4net code and 
compile it with Visual C++. So down the road I can see if I can get 64 bit 
version packaged and submitted as PR to icu4net project or package it as our 
own or something like that.
    
    Anyway, do let me know if you think we should use something else for 
BreakIterator implementations or go with this. It does seem like the ICU 
project implements other components that Analysis uses that have no equivalent 
in .NET (e.g. Collations concept). I am completely new to ICU project but it 
appears to be very active and has regular meetings and released.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet analysis_chararrayiterator

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #157
    
----
commit 03d0950fac054c2e709e6a30aecca25baa2c34a2
Author: Laimonas Simutis <[email protected]>
Date:   2015-12-17T01:30:34Z

    port CharArrayIterator

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to