Github user NightOwl888 commented on the issue:

    https://github.com/apache/lucenenet/pull/191
  
    >This is a bug in nunit/dotnet-test-nunit#76. I updated the test projects 
to dotnet-test-nunit beta3. This should be resolved now.
    
    > All the solutions, Lucene.Net.sln and Lucene.Net.Portable.sln open in 
Visual Studio 2015 now. I removed support for Visual Studio 2013 to make the 
experience consistent. You should be able to run the tests if you install the 
NUnit 3.0 VS extension in 2015.
    
    Good job Connie. I can now see and run all of the tests when opening 
Lucene.Net.sln. Also, I can run the script to build, pack, and run tests for 
Lucene.Net.Portable.sln.
    
    Now, if we could only get them to run faster... 😟 It took 8:12 to run 
the 143 Lucene.Net.Tests.Suggest tests on .NET Core! That is about 8x longer 
than it takes on master.
    
    > I migrated the projects and their associated test projects, 
Lucene.Net.Analysis.Stempel, Lucene.Net.Tests.Grouping and 
Lucene.Net.Tests.Analysis.Stempel. Last thing I need to do is merge in your 
recent changes to master with Lucene.Net.Spatial. Is there anything else I am 
missing?
    
    Yes.
    
    1. I opened a pull request for Collation (a small namespace in 
Analysis.Common): https://github.com/conniey/lucenenet/pull/25. Not sure if you 
didn't mention it because it is not critical to getting this branch merged or 
if you were unaware of this task. Note there are still 4 failing tests and I 
suspect there may need to be updates to icu-dotnet in order to fix them.
    2. Typically when I make a build script I include a way to set the version 
number from the CLI so the binaries can be built and NuGet packaged without 
having to manually update the version number in several locations. This is 
helpful if, for example, you need to be able to create packages outside of the 
normal CI process (for example, it might take some of the pressure off if we 
could make a build from this branch and upload it manually). It also opens the 
door if you need to any customizations other than the typical "patch 
AssemblyInfo.cs" that is available in CI environments (such as setting the 
copyright year to the current year). I don't see an option for version in the 
Build.ps1 file - is this something that is built into the new .NET tooling? Or 
is there another existing way to handle versioning that doesn't involve 
updating dozens of files?
    3. Please add any build artifact directories (such as NuGetPackages) to the 
.gitignore file so the files don't accidentally get committed.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to