Github user jeme commented on the pull request:

    
https://github.com/apache/lucenenet/commit/34ef2ce56c48beeb36e3a608c5339b84b36a5414#commitcomment-24323041
  
    In that case I would probably advocate for adding a overloaded constructor:
    
    ```CSharp
    public ReplicationService(IDictionary<string, IReplicator> replicators, 
string context = REPLICATION_CONTEXT) : this(new 
ReadOnlyDictionary(replicators), context) { }
    ```
    Or something... That would ease the use for those that wanted to use it in 
a completely different context.
    
    I am not sure how much is it spread out or if it's actually all in the 
first commit, but that is here: 
https://github.com/jeme/lucenenet/commit/a08f43e9472e6e65680f1cddd3a9339d9550b53f
    
    But Pulling that in directly is probably requires more effort that just 
going though the code and finding the places where Readonly makes sense as the 
code as moved a bit since then.


---

Reply via email to