laimis commented on code in PR #801:
URL: https://github.com/apache/lucenenet/pull/801#discussion_r1162257195
##########
src/Lucene.Net/Search/IndexSearcher.cs:
##########
@@ -161,7 +161,9 @@ public IndexSearcher(IndexReaderContext context)
/// Each <see cref="LeafSlice"/> is executed in a single thread. By
default there
/// will be one <see cref="LeafSlice"/> per leaf (<see
cref="AtomicReaderContext"/>).
/// </summary>
- protected virtual LeafSlice[] Slices(IList<AtomicReaderContext> leaves)
+ // LUCENENET specific - S1699 - marked non-virtual because calling
+ // virtual members from the constructor is not a safe operation in .NET
+ protected LeafSlice[] Slices(IList<AtomicReaderContext> leaves)
Review Comment:
Fixed in https://github.com/apache/lucenenet/pull/818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
