laimis commented on code in PR #801:
URL: https://github.com/apache/lucenenet/pull/801#discussion_r1161271932
##########
src/Lucene.Net.QueryParser/Flexible/Standard/Nodes/NumericRangeQueryNode.cs:
##########
@@ -87,7 +87,9 @@ private static NumericType
GetNumericDataType(J2N.Numerics.Number number)
/// <param name="lowerInclusive"><c>true</c> if the lower bound is
inclusive, otherwise, <c>false</c></param>
/// <param name="upperInclusive"><c>true</c> if the upper bound is
inclusive, otherwise, <c>false</c></param>
/// <param name="numericConfig">the <see cref="Config.NumericConfig"/>
that represents associated with the upper and lower bounds</param>
- public virtual void SetBounds(NumericQueryNode lower, NumericQueryNode
upper,
+ // LUCENENET specific - S1699 - marked non-virtual because calling
+ // virtual members from the constructor is not a safe operation in .NET
+ public void SetBounds(NumericQueryNode lower, NumericQueryNode upper,
Review Comment:
Fixed in https://github.com/apache/lucenenet/pull/812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
