NightOwl888 commented on code in PR #981:
URL: https://github.com/apache/lucenenet/pull/981#discussion_r1809537813
##########
src/dotnet/tools/lucene-cli/lucene-cli.csproj:
##########
@@ -24,11 +24,11 @@
<Import Project="$(SolutionDir).build/nuget.props" />
<PropertyGroup>
- <TargetFrameworks>net8.0;net6.0</TargetFrameworks>
+ <TargetFrameworks>net8.0</TargetFrameworks>
<RollForward Condition=" $(TargetFramework.StartsWith('net8.'))
">Major</RollForward>
<IsPublishable>false</IsPublishable>
- <IsPublishable Condition="'$(TargetFramework)' == 'net8.0' Or
'$(TargetFramework)' == 'net6.0'">true</IsPublishable>
Review Comment:
The `<TargetFrameworks>` are specified above. `<TargetFramework>` has the
condition. The solution level publish runs all of the targets, so we need the
condition on `<TargetFramework>` to exclude the ones that don't apply in CI.
This was recently updated in #975, which failed because `net5.0` was allowed to
publish with the previous condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
