paulirwin commented on code in PR #981:
URL: https://github.com/apache/lucenenet/pull/981#discussion_r1809562702
##########
src/dotnet/tools/lucene-cli/lucene-cli.csproj:
##########
@@ -24,11 +24,11 @@
<Import Project="$(SolutionDir).build/nuget.props" />
<PropertyGroup>
- <TargetFrameworks>net8.0;net6.0</TargetFrameworks>
+ <TargetFrameworks>net8.0</TargetFrameworks>
<RollForward Condition=" $(TargetFramework.StartsWith('net8.'))
">Major</RollForward>
<IsPublishable>false</IsPublishable>
- <IsPublishable Condition="'$(TargetFramework)' == 'net8.0' Or
'$(TargetFramework)' == 'net6.0'">true</IsPublishable>
Review Comment:
If I understand correctly, does this mean that we are running the CLI tests
for each target framework (.NET 6, .NET 8, etc) but always running it as .NET 8
no matter what? If so, that seems wasteful, and we could speed up our test
times a little by only running it as part of the .NET 8 tests. But alas, I'm
not going to fix what ain't broken here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
