NightOwl888 commented on code in PR #1018:
URL: https://github.com/apache/lucenenet/pull/1018#discussion_r1842607521
##########
src/Lucene.Net.Tests/Codecs/Compressing/TestCompressingStoredFieldsFormat.cs:
##########
@@ -35,6 +35,7 @@ namespace Lucene.Net.Codecs.Compressing
using MockAnalyzer = Lucene.Net.Analysis.MockAnalyzer;
using RandomIndexWriter = Lucene.Net.Index.RandomIndexWriter;
+ // LUCENENET: Moved @Repeat(iterations=5) to the method level
Review Comment:
This codec is enabled by default, so I think we should test it the same way
Lucene did.
So, we will need to add the overrides back in so we can add the attribute to
*every method*. I guess it really is a `[RepeatAttribute]` 😄. The overrides
once existed in every subclass that had an abstract base class, so work can be
saved by searching the git history to recover them. At least let's put the
value 5 in a const so we don't have to repeat that, also (if possible).
Overriding the methods is still technically necessary until #923 is fixed,
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
