paulirwin commented on code in PR #1018:
URL: https://github.com/apache/lucenenet/pull/1018#discussion_r1845070935
##########
src/Lucene.Net.Tests/Analysis/TokenAttributes/TestCharTermAttributeImpl.cs:
##########
@@ -230,9 +230,7 @@ public virtual void TestAppendableInterface()
t.Append((ICharSequence)t2, 1, 5 - 1); // LUCENENET: Corrected
3rd parameter
Review Comment:
The ICharTermAttribute change would be breaking, so I'll do that as a
separate PR. I have these changes working locally; just need to add tests for
these specific span-based versions of Append.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
