paulirwin commented on PR #1172:
URL: https://github.com/apache/lucenenet/pull/1172#issuecomment-3258245793

   > I think a way around that may be to simply add the $(TargetFramework) and 
OS to the cache key.
   
   That's not really the problem (or solution), sorry, I should have been 
clearer. If the lock files have all of our target frameworks in source control, 
it would have no problem restoring the packages on macOS or Linux build agents, 
where the cache would be used, so there's no need to differentiate that by OS 
AFAICT (at least not for this specific problem). The problem I was referring to 
above is that for _contributors building on macOS or Linux_, the lock files are 
regenerated on our dev machines each time we build since it doesn't have that 
target. That makes it at best highly annoying to avoid having to commit those 
files. I suppose most of the "at worst" scenarios are protected by CI builds... 
so perhaps this isn't a "blocker" but more of an "extremely annoying impediment 
to contribution."
   
   Because of that, I'll reopen this and leave it as draft, and see if anyone 
has any other ideas. We can also revisit this in the future if we are able to 
upgrade IKVM without using Mono, accept Mono as an annoying contributor 
requirement (and go through the work of adding it to our CI pipelines), or 
(fingers crossed) drop .NET Framework support (at least for Analysis.OpenNLP) 
in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to