paulirwin commented on PR #1172: URL: https://github.com/apache/lucenenet/pull/1172#issuecomment-3256944097
I found a blocker to adopting the packages.lock.json files approach, at least for now. We currently have to conditionally exclude building the net472 target on macOS (my daily driver OS, for example), because the version of ikvm-maven we use has a bug building for it. This bug has been resolved upstream, but there are two issues with updating it currently: 1. The fix requires having mono available on the system in order to build the net472 target. While not insurmountable, this is an annoying limitation and will make it more difficult for people to contribute. 2. The ikvm-maven updates target a newer version of IKVM, and apparently we can't upgrade because of [a size limitation on Azure DevOps build agents](https://github.com/apache/lucenenet/blob/f38de47d8ddac674065f04034e44c2122dd89620/src/Lucene.Net.Analysis.OpenNLP/Lucene.Net.Analysis.OpenNLP.csproj#L57-L58). And the reason why this is a problem is that if you conditionally exclude a target framework on a platform, then the lock files get regenerated on build/restore without that target included. While I think we need to solve the IKVM-upgrade problem (hopefully with a solution that does not involve Mono), I don't think "the juice is worth the squeeze" for this optimization at this time. I'm going to close this PR for now, but we can always resume this work later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
