NehanPathan commented on code in PR #1182:
URL: https://github.com/apache/lucenenet/pull/1182#discussion_r2338352767
##########
src/Lucene.Net.Replicator/Http/HttpClientBase.cs:
##########
@@ -217,6 +240,31 @@ private string QueryString(string request, params string[]
parameters)
.Join("&",
parameters.Select(WebUtility.UrlEncode).InPairs((key, val) =>
string.Format("{0}={1}", key, val))));
}
+ // Add this property so subclasses can access the HttpClient instance
+ protected HttpClient Client => httpc;
+
+ // BuildUrl helpers (mirror the QueryString overloads)
+ protected virtual string BuildUrl(string action, string[] parameters)
Review Comment:
@NightOwl888
Sorry — initially while implementing async, I had put the ExecuteGetAsync
methods in the subclass and used BuildUrl from the base class. Later I realized
the sync ExecuteGet methods were already in HttpClientBase, so I shifted the
async ones there as well for consistency. But I forgot to remove the extra
BuildUrl wrappers (and the Client property), which are no longer needed since
everything goes through QueryString inside HttpClientBase.
I’ll clean those up now.
thanks for that....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
