NightOwl888 commented on code in PR #1182:
URL: https://github.com/apache/lucenenet/pull/1182#discussion_r2338631014
##########
src/Lucene.Net.Replicator/ReplicationClient.cs:
##########
@@ -261,6 +279,101 @@ private void DoUpdate()
}
}
+ /// <summary>
+ /// Performs the async update logic, mirrors DoUpdate but uses
IAsyncReplicator.
+ /// </summary>
+ private async Task DoUpdateAsync(CancellationToken cancellationToken)
+ {
+ if (asyncReplicator is null)
+ throw new InvalidOperationException("AsyncReplicator not
initialized.");
+
+ SessionToken? session = null;
Review Comment:
@NehanPathan
`#nullable enable` can be turned off again using `#nullable restore`. While
it is preferable to solve all of the nullable issues rather than ignore them,
this at least lets us put them off until they can be considered separately from
ongoing work. I would highly recommend that the new code we are adding is
fenced between `#nullable enable` and `#nullable restore` blocks, which will
save us the work of having to do it all later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
