paulirwin commented on code in PR #1222:
URL: https://github.com/apache/lucenenet/pull/1222#discussion_r2554475356
##########
.github/workflows/Generate-TestWorkflows.ps1:
##########
@@ -284,6 +287,12 @@ jobs:
uses: actions/setup-dotnet@v5
with:
dotnet-version: '$DotNet9SDKVersion'
+ if: `${{ startswith(matrix.framework, 'net9.') }}
+
+ - name: Setup .NET 10 SDK
+ uses: actions/setup-dotnet@v5
+ with:
+ dotnet-version: '$DotNet10SDKVersion'
Review Comment:
> As pointed out, the latest SDK is always installed when specifying a lower
one.
That is not quite how I read the discussion. It was that the latest _host
and runtime_ is installed, then it installs your specified _SDK_ version. This
is shown in the logs you shared on that comment thread (note the Runtime vs Sdk
difference in the URLs):
```
un actions/setup-dotnet@v5
(node:10216) [DEP0040] DeprecationWarning: The `punycode` module is
deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
"C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -Sta -NoProfile
-NonInteractive -ExecutionPolicy Unrestricted -Command &
'D:\a\_actions\actions\setup-dotnet\v5\externals\install-dotnet.ps1'
-SkipNonVersionedFiles -Runtime dotnet -Channel LTS
dotnet-install: Downloaded file
https://builds.dotnet.microsoft.com/dotnet/Runtime/10.0.0/dotnet-runtime-10.0.0-win-x64.zip
size is 37111780 bytes.
dotnet-install: Either downloaded or local package size can not be measured.
One of them may be corrupted.
dotnet-install: Extracting the archive.
dotnet-install: Note that the script does not ensure your Windows version is
supported during the installation.
dotnet-install: To check the list of supported versions, go to
https://learn.microsoft.com/dotnet/core/install/windows#supported-versions
dotnet-install: Installed version is 10.0.0
dotnet-install: Installation finished
"C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -Sta -NoProfile
-NonInteractive -ExecutionPolicy Unrestricted -Command &
'D:\a\_actions\actions\setup-dotnet\v5\externals\install-dotnet.ps1'
-SkipNonVersionedFiles -Channel 8.0
dotnet-install: Downloaded file
https://builds.dotnet.microsoft.com/dotnet/Sdk/8.0.416/dotnet-sdk-8.0.416-win-x64.zip
size is 285854895 bytes.
dotnet-install: Either downloaded or local package size can not be measured.
One of them may be corrupted.
dotnet-install: Extracting the archive.
dotnet-install: Note that the script does not ensure your Windows version is
supported during the installation.
dotnet-install: To check the list of supported versions, go to
https://learn.microsoft.com/dotnet/core/install/windows#supported-versions
dotnet-install: Installed version is 8.0.416
dotnet-install: Installation finished
```
So I think we have to keep this so that we have the .NET 10 SDK installed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
