NightOwl888 commented on code in PR #1222:
URL: https://github.com/apache/lucenenet/pull/1222#discussion_r2554968314
##########
src/dotnet/tools/lucene-cli/lucene-cli.csproj:
##########
@@ -24,11 +24,10 @@
<Import Project="$(SolutionDir).build/nuget.props" />
<PropertyGroup>
- <TargetFrameworks>net8.0</TargetFrameworks>
- <RollForward Condition=" $(TargetFramework.StartsWith('net8.'))
">Major</RollForward>
+ <TargetFrameworks>net10.0;net8.0</TargetFrameworks>
+ <RollForward Condition=" $(TargetFramework.StartsWith('net8.')) Or
$(TargetFramework.StartsWith('net10.')) ">Major</RollForward>
- <IsPublishable>false</IsPublishable>
- <IsPublishable Condition="'$(TargetFramework)' ==
'net8.0'">true</IsPublishable>
+ <IsPublishable Condition="' $(TargetFramework.StartsWith('net8.')) Or
$(TargetFramework.StartsWith('net10.')) '">true</IsPublishable>
Review Comment:
The tests are failing due to the extra single quotes around this condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
