[GitHub] madlib pull request #191: KNN: Fix optional parameters and ordering

[iyerr3]

Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/191#discussion_r146646897
  
    --- Diff: src/ports/postgres/modules/knn/knn.py_in ---
    @@ -135,13 +135,17 @@ def knn(schema_madlib, point_source, 
point_column_name, point_id, label_column_n
             test_id_temp = unique_string(desp='test_id_temp')
     
             if output_neighbors is None or '':
    -            output_neighbors = False
    +            output_neighbors = True
    --- End diff --
    
    We should give this flag a different name from the input string variable. 


---