Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/191#discussion_r146702329
--- Diff: src/ports/postgres/modules/knn/knn.py_in ---
@@ -135,13 +135,17 @@ def knn(schema_madlib, point_source,
point_column_name, point_id, label_column_n
test_id_temp = unique_string(desp='test_id_temp')
if output_neighbors is None or '':
- output_neighbors = False
+ output_neighbors = True
--- End diff --
On second read of the code: output_neighbors is already a boolean. Is there
a reason to expect it to be `''`?
---
