Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/211#discussion_r155598729
  
    --- Diff: deploy/gppkg/CMakeLists.txt ---
    @@ -2,8 +2,11 @@
     # Packaging for Greenplum's gppkg
     # 
------------------------------------------------------------------------------
     
    -set(MADLIB_GPPKG_VERSION "1.9.9")
    -set(MADLIB_GPPKG_RELEASE_NUMBER 1)
    +# not used now
    +# set(MADLIB_GPPKG_VERSION "1.9.9")
    --- End diff --
    
    IMO, we can delete this. Don't need to keep it for posterity. 


---

Reply via email to