Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/211#discussion_r155599007
  
    --- Diff: src/ports/greenplum/cmake/GreenplumUtils.cmake ---
    @@ -17,6 +17,9 @@ function(add_gppkg GPDB_VERSION GPDB_VARIANT 
GPDB_VARIANT_SHORT UPGRADE_SUPPORT)
         string(TOLOWER ${GPDB_VERSION} GPDB_VERSION_LC)
         string(REPLACE "." "_" VERSION_ "${GPDB_VERSION}")
     
    +    # Get information about the rhel version
    +    rh_major_version(RH_VERSION)
    --- End diff --
    
    `RPM/cmakelists.txt` is also setting `RH_VERSION`. How about we call this 
RH_MAJOR_VERSION?


---

Reply via email to