Github user kaknikhil commented on the issue:

    https://github.com/apache/madlib/pull/271
  
    A few other observations from madpack output
    
    1. While uninstalling , this message is printed on the console’
    `madpack.py: INFO : Installing MADlib modules` We should instead say that 
we are uninstalling modules.
    
    1. In case of failure, the output looks something like `MADlib upgrade 
unsuccessful.` It would be nice to also say that everything was rolled back.
    
    1. I also noticed that the output messages have changed a bit for 
install/uninstall/reinstall and upgrade
    
    old output 
    ```
    madpack.py: INFO : Installing MADlib into MADLIB schema...
    madpack.py: INFO : > Creating MADLIB schema
    madpack.py: INFO : > Creating MADLIB.MigrationHistory table
    madpack.py: INFO : > Writing version info in MigrationHistory table
    madpack.py: INFO : > Creating objects for modules:
    madpack.py: INFO : > - array_ops
    madpack.py: INFO : > - bayes
    ...
    ...
    madpack.py: INFO : > - validation
    madpack.py: INFO : MADlib 1.13 installed successfully in MADLIB schema.
    ``` 
    
    new output
    ```
    madpack.py: INFO : Testing PL/Python environment...
    madpack.py: INFO : > Creating language PL/Python...
    madpack.py: INFO : > PL/Python environment OK (version: 2.7.14)
    madpack.py: INFO : > Preparing objects for modules:
    madpack.py: INFO : > - array_ops
    madpack.py: INFO : > - bayes
    ...
    ...
    madpack.py: INFO : > - validation
    madpack.py: INFO : Installing MADlib modules...
    madpack.py: INFO : > Created MADLIB schema
    madpack.py: INFO : > Created MADLIB.MigrationHistory table
    madpack.py: INFO : > Wrote version info in MigrationHistory table
    madpack.py: INFO : MADlib 1.15-dev installed successfully in MADLIB schema.
    ```
    I think the previous message was better because all the modules were 
printed after `Installing MADlib into MADLIB schema` instead of after 
`Preparing objects for modules`. And with the new output`Installing MADlib 
modules...` is followed by `Created madlib schema` which looks a bit weird.


---

Reply via email to