Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/271#discussion_r191609335
--- Diff: src/madpack/madpack.py ---
@@ -537,9 +629,8 @@ def _db_upgrade(schema, dbrev):
ch.drop_changed_udf()
ch.drop_changed_udt() # assume dependent udf for udt does not change
ch.drop_traininginfo_4dt() # used types: oid, text, integer, float
- _db_create_objects(schema, None, True, sc)
-
- info_(this, "MADlib %s upgraded successfully in %s schema." %
(str(rev), schema.upper()), True)
+ _db_create_objects(schema, filehandle, True, sc)
--- End diff --
can we rewrite this as
```python
_db_create_objects(schema, filehandle, upgrade=True, sc=sc)
```
---
