kaknikhil commented on a change in pull request #393: DL: Add support for
reporting various metrics in fit/evaluate
URL: https://github.com/apache/madlib/pull/393#discussion_r286268390
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -637,13 +642,21 @@ def internal_keras_eval_transition(state, dependent_var,
independent_var,
with K.tf.device(device_name):
res = model.evaluate(x_val, y_val)
- loss, metric = res
+ # if metric is None, model.evaluate will only return loss as a scalar
Review comment:
Maybe we should also assert the len of res cannot be > 2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
