kaknikhil commented on a change in pull request #393: DL: Add support for
reporting various metrics in fit/evaluate
URL: https://github.com/apache/madlib/pull/393#discussion_r286264633
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_serializer.py_in
##########
@@ -59,8 +58,16 @@ def deserialize_weights(model_state, model_shapes):
weight_arr_portion = model_weights_serialized[i:next_pointer]
model_weights.append(weight_arr_portion.reshape(model_shapes[j]))
i, j = next_pointer, j + 1
+ #TODO: float(state[0]) is the image_count, which can be get from
+ # get_image_count_from_state() we defined below, we should check if
+ # we still need to return it here when refactoring
return float(state[0]), model_weights
+def get_image_count_from_state(model_state):
Review comment:
+1 for this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
