kaknikhil commented on a change in pull request #423: Association Rules: 
Improve performance
URL: https://github.com/apache/madlib/pull/423#discussion_r305948252
 
 

 ##########
 File path: src/ports/postgres/modules/assoc_rules/assoc_rules.py_in
 ##########
 @@ -247,6 +259,19 @@ def assoc_rules(madlib_schema, support, confidence, 
tid_col,
         m4_ifdef(`__POSTGRESQL__', `', `DISTRIBUTED BY (id)')
         """.format(madlib_schema, madlib_schema));
 
+    plpy.execute("DROP TABLE IF EXISTS assoc_rule_sets_loop_ordered");
 
 Review comment:
   Can we explain the purpose of creating these three tables assoc_rule_sets, 
assoc_rule_sets_loop and assoc_rule_sets_loop_ordered?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to