kaknikhil commented on a change in pull request #423: Association Rules:
Improve performance
URL: https://github.com/apache/madlib/pull/423#discussion_r306021387
##########
File path: src/ports/postgres/modules/assoc_rules/test/assoc_rules.sql_in
##########
@@ -137,29 +144,63 @@ begin
assoc_array_eq(t1.post, t2.post) AND
abs(t1.support - t2.support) < 1E-10 AND
abs(t1.confidence - t2.confidence) < 1E-10;
+ IF (result2 = 'FAIL') THEN
Review comment:
Do we have tests that check for the support and confidence values ? If not,
it might be a good time to add them to prevent any future regressions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
