khannaekta opened a new pull request #476: DL: Avoid constant folding of weights in GPDB6 plan URL: https://github.com/apache/madlib/pull/476 For versions >=GPDB6, previously, for queries called with the initial weights value passed in, the query plan for it would have create custom plans with weights embedded in the plan itself. This meant that the query plan size would also include the size of these weights, bloating it up to hit the 1GB limit when dispatching the query plan to segments, leading to OOM for large weights. In GPDB, for PREPARE plans, there is a threshold of 5 attempts to create custom plans(constant folding the passed in params) for execution and then it uses a generic plan(not constant folding the passed in params) for all the subsequent executions. Therefore, to avoid GPDB6 from creating custom plans when passing in weights, the queries(with weights) is executed with DUMMY weights for 5 time, prior to calling it with the actual weights. <!-- Thanks for sending a pull request! Here are some tips for you: 1. Refer to this link for contribution guidelines https://cwiki.apache.org/confluence/display/MADLIB/Contribution+Guidelines 2. Please Provide the Module Name, a JIRA Number and a short description about your changes. --> - [x] Add the module name, JIRA# to PR/commit and description. - [ ] Add tests for the change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
