orhankislal commented on a change in pull request #476: DL: Avoid constant
folding of weights in GPDB6 plan
URL: https://github.com/apache/madlib/pull/476#discussion_r374856844
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_helper.py_in
##########
@@ -314,3 +315,7 @@ def get_accessible_gpus_for_seg(schema_madlib,
segments_per_host, module_name):
'recommended configuration is to have 1 GPU available per
segment.')
warning_flag = False
return accessible_gpus_for_seg
+
+def is_platform_gp6():
+ version_wrapper = __mad_version()
+ return version_wrapper.is_gp_version_less_than('6.0')
Review comment:
What will happen if the version is gpdb5? `is_gp_version_less_than` implies
that it should return true but the function name `is_platform_gp6` implies that
it should return false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
