orhankislal commented on a change in pull request #491: DL: Fix disk issue by
using truncate guc
URL: https://github.com/apache/madlib/pull/491#discussion_r396830491
##########
File path: src/ports/postgres/modules/utilities/utilities.sql_in
##########
@@ -541,3 +541,49 @@ BEGIN
RETURN 0;
END;
$$ LANGUAGE plpgsql;
+
+CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.is_ver_greater_than_gp_640_or_pg_11()
Review comment:
I understand why we need this very specific function but it would be great
to add a few lines of comments for context. It is especially confusing because
the function is in utilities and I usually expect them to be somewhat generic.
Please note that I am not suggesting to move the function to DL, just some
comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
