kaknikhil commented on a change in pull request #491: DL: Fix disk issue by
using truncate guc
URL: https://github.com/apache/madlib/pull/491#discussion_r396835067
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_fit_multiple_model.py_in
##########
@@ -648,8 +651,9 @@ class FitMultipleModel():
with SetGUC("dev_opt_unsafe_truncate_in_subtransaction", "on"):
temp_model_table = unique_string('updated_model')
+ self.unlogged_table = self.unlogged_table if not
self.is_final_training_call else ''
Review comment:
```suggestion
unlogged_table = self.unlogged_table if not self.is_final_training_call else
''
plpy.execute("""CREATE {unlogged_table} TABLE {temp_model_table} ( LIKE
{self.model_output_table}""")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
