khannaekta commented on pull request #498: URL: https://github.com/apache/madlib/pull/498#issuecomment-631706018
For (1), (4): will update code for the changes For (3), (5): These are expected behaviors aligned with model arch table load/delete helper functions. - For (3), since `id` is a sequence, if delete is called between loads, it will skip the deleted id - For (5), Kept it consistent with model arch table delete function, we can keep the table empty too, but it makes more sense to delete it as it would anyways be created on calling load with the same tablename. Below is the flow for load/delete model arch table as well as custom function table: ``` load() -> Creates table id =1 load() -> insert into table id =2 delete(id=2) -> delete from table id =2 load() -> insert into table id =3 delete(id=3) -> delete from table id =3 delete(id=1) -> delete from table id =1 and drop table ``` For (2): When I try to load an object with same function name(on GPDB6), it fails with the following error: I ran the following (2 times): ``` Function 'sum_fn1' already exists in new_tab ``` It's unable to catch that exception with GPDB5. They are probably different, but I will look into it a little more ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
