fmcquillan99 edited a comment on pull request #498:
URL: https://github.com/apache/madlib/pull/498#issuecomment-631799555


   (1)
   Delete by name
   
   ```
   SELECT madlib.delete_custom_function( 'test_custom_function_table', 
'mult_fn');
   INFO:  Keras Custom Function: Object id None has been deleted from 
test_custom_function_table.
   CONTEXT:  PL/Python function "delete_custom_function"
    delete_custom_function 
   ------------------------
   ```
   OK
   
   
   (2)
   better error message:
   
   ```
   InternalError: (psycopg2.errors.InternalError_) plpy.Error: Function 
'sum_fn' already exists in test_custom_function_table (plpython.c:5038)
   CONTEXT:  Traceback (most recent call last):
     PL/Python function "load_custom_function", line 21, in <module>
       madlib_keras_custom_function.load_custom_function(**globals())
     PL/Python function "load_custom_function", line 42, in wrapper
     PL/Python function "load_custom_function", line 98, in load_custom_function
   PL/Python function "load_custom_function"
   
   [SQL: SELECT madlib.load_custom_function('test_custom_function_table', 
custom_function_object_sum(), 'sum_fn', 
                                      'returns sum');]
   (Background on this error at: http://sqlalche.me/e/2j85)
   ```
   OK
   
   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to