reductionista commented on a change in pull request #505:
URL: https://github.com/apache/madlib/pull/505#discussion_r457784339
##########
File path: src/ports/postgres/modules/dbscan/dbscan.py_in
##########
@@ -282,7 +777,8 @@ SELECT {schema_madlib}.dbscan(
min_samples, -- The minimum size of a cluster
metric, -- The name of the function to use to calculate the
-- distance
- algorithm -- The algorithm to use for dbscan.
+ algorithm, -- The algorithm to use for dbscan
Review comment:
I had to look at the source code to figure out what to use for `metric`,
after taking a few guesses. Maybe we can list the valid choices here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
